RDKB-63473, RDKB-63485: Update RFC Defaults for meminsight#243
Merged
GoutamD2905 merged 2 commits intodevelopfrom Mar 2, 2026
Merged
RDKB-63473, RDKB-63485: Update RFC Defaults for meminsight#243GoutamD2905 merged 2 commits intodevelopfrom
GoutamD2905 merged 2 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates RFC defaults for the meminsight tool across three platform-specific system default files. The changes standardize the comment from "xMemInsight" to "meminsight" and introduce a new xMemTrigger configuration variable with a default value of "stop". This is a follow-up to RDKB-60957 which initially added meminsight defaults.
Changes:
- Standardized comment from "Defaults for xMemInsight" to "Defaults for meminsight"
- Added new
$xMemTrigger=stopdefault variable for xd4 and arm platforms - Added commented
#xMemTrigger=stopfor bci platform (following platform-specific convention)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| source/scripts/init/defaults/system_defaults_xd4 | Updated comment and added active xMemTrigger default |
| source/scripts/init/defaults/system_defaults_bci | Updated comment and added commented xMemTrigger default |
| source/scripts/init/defaults/system_defaults_arm | Updated comment and added active xMemTrigger default |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gomathishankar37
changed the title
GoutamD2905
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Add RFC Params defaults for for meminsight based RFCs (Enable, Trigger & Args)
Test Procedure: Build and verify
Risks: Medium
Priority: P1